Welcome
Welcome to xnaquickstart

You are currently viewing our boards as a guest, which gives you limited access to view most discussions and access our other features. By joining our free community, you will have access to post topics, communicate privately with other members (PM), respond to polls, upload content, and access many other special features. Registration is fast, simple, and absolutely free, so please, join our community today!

Minor Bug: IUpdateable Implementations

If you think you've found a bad bug in the framework, post here

Moderators: Coordinators, Developers

Minor Bug: IUpdateable Implementations

Postby Zpoon on Sun Jun 29, 2008 5:43 pm

I was just looking through the code and saw the following code in BaseManager and Inputmanager:
Code: Select all
public bool Enabled
        {
            get { return this.enabled; }
            set
            {
                this.enabled = true;
                this.OnEnabledChanged();
                this.OnPropertyChanged(PropertyName.Enabled);
            }
        }


I think this defines a behavior you dont want. because this.enabled will always be set to true. if you always want enabled to be true removing the setter would be the best option. and just return true in the getter and get rid of the enabled property. Or when you would keep the setter i suggest you replace the this.enabled = true by this.enabled = value.
Zpoon
Beginner
 
Posts: 1
Joined: Sun Jun 29, 2008 4:15 pm

Postby lordikon on Mon Jun 30, 2008 9:27 pm

Hmmm, I'm not sure who set this up, it certainly could be a bug. I don't think we've ever disabled a manager so I don't think it has come up. Thanks for the heads up.
User avatar
lordikon
Administrator
 
Posts: 342
Joined: Thu Apr 03, 2008 11:26 pm
Location: Colorado


Return to Bug Reports

Who is online

Users browsing this forum: No registered users and 0 guests

cron